Skip to content

gh-78707: deprecate passing >1 argument to PurePath.[is_]relative_to() #94469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 8 commits into from
Dec 17, 2022
Merged

gh-78707: deprecate passing >1 argument to PurePath.[is_]relative_to() #94469

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
594bd8f
gh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()`
barneygale Jun 30, 2022
3268a10
Address review feedback
barneygale Jul 9, 2022
0e79a85
Merge branch 'main' into gh-78707-pathlib-relative-to-arguments
barneygale Nov 25, 2022
7e8e553
Use new deprecation mechanism
barneygale Nov 25, 2022
6ac36fc
Fix dodgy merge
barneygale Nov 25, 2022
00e6677
Tweak NEWS now we have `walk_up`.
barneygale Nov 25, 2022
6e966ba
Make deprecation notices uniform.
barneygale Nov 25, 2022
0374a35
Apply suggestions from code review
barneygale Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make deprecation notices uniform.
  • Loading branch information
@barneygale
barneygale committed Nov 25, 2022
commit 6e966baa484594ab6199aab3de9f0622635ba239
8 changes: 4 additions & 4 deletions Doc/library/pathlib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,8 +504,8 @@ Pure paths provide the following methods and properties:

.. deprecated:: 3.12
Comment thread
barneygale marked this conversation as resolved.
Outdated

Support for supplying additional arguments is deprecated; if supplied,
they are joined with *other*.
Passing additional arguments is deprecated; if supplied, they are joined
with *other*.

.. method:: PurePath.is_reserved()

Expand Down Expand Up @@ -611,8 +611,8 @@ Pure paths provide the following methods and properties:

.. deprecated:: 3.12
Comment thread
barneygale marked this conversation as resolved.
Outdated

Passing additional arguments is deprecated; if supplied, they are joined
with *other*.
Passing additional positional arguments is deprecated; if supplied,
they are joined with *other*.

.. method:: PurePath.with_name(name)

Expand Down