gh-94332: make it safe to call assemble_free when assemble_init has not been called - #94389
Merged
Conversation
… has not been called
markshannon
approved these changes
Jun 30, 2022
Contributor
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Contributor
|
Sorry, @iritkatriel, I could not cleanly backport this to |
Contributor
|
Sorry @iritkatriel, I had trouble checking out the |
|
GH-94442 is a backport of this pull request to the 3.11 branch. |
|
GH-94443 is a backport of this pull request to the 3.10 branch. |
iritkatriel
added a commit
that referenced
this pull request
Jun 30, 2022
iritkatriel
added a commit
that referenced
this pull request
Jun 30, 2022
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this pull request
Jun 30, 2022
… has not been called (pythonGH-94389)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assemble()can callassemble_freewithout having calledassemble_init(), resulting in a segfault. #94332