Skip to content

gh-94026: Buffer regrtest worker stdout in temporary file (GH-94253) #94253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiran merged 3 commits into from
Jun 29, 2022
+38 −39
Merged

gh-94026: Buffer regrtest worker stdout in temporary file (GH-94253) #94253

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
198027a
gh-94026: Buffer regrtest worker stdout in temporary file
tiran Jun 25, 2022
141d491
Address review
tiran Jun 29, 2022
bd76060
get retcode directly
tiran Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
get retcode directly
  • Loading branch information
@tiran
tiran committed Jun 29, 2022
commit bd760602ce534d95374a2bd2ef6fb57a4913866b
3 changes: 1 addition & 2 deletions Lib/test/libregrtest/runtest_mp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,7 @@ def _run_process(self, test_name: str, tmp_dir: str, stdout_fh: TextIO) -> int:

try:
# gh-94026: stdout+stderr are written to tempfile
popen.wait(timeout=self.timeout)
retcode = popen.returncode
retcode = popen.wait(timeout=self.timeout)
assert retcode is not None
return retcode
except subprocess.TimeoutExpired:
Expand Down