Skip to content

gh-94101 Disallow instantiation of SSLSession objects #94102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 2 commits into from
Jun 22, 2022
Merged

gh-94101 Disallow instantiation of SSLSession objects #94102

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5179652
Disallow instantiation of SSLSession objects
chgnrdv Jun 21, 2022
319fb4e
Add Blurb
ambv Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disallow instantiation of SSLSession objects 
Directly instantiated SSLSession objects don't make much sense, but attribute lookup on them causes segmentation fault. This commit makes SSLSession objects non-instantiable.
  • Loading branch information
@chgnrdv
chgnrdv committed Jun 21, 2022
commit 51796521f54162543435b673a1b6b65deaf170f3
3 changes: 2 additions & 1 deletion Modules/_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5067,7 +5067,8 @@ static PyType_Spec PySSLSession_spec = {
.name = "_ssl.SSLSession",
.basicsize = sizeof(PySSLSession),
.flags = (Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC |
Py_TPFLAGS_IMMUTABLETYPE),
Py_TPFLAGS_IMMUTABLETYPE |
Py_TPFLAGS_DISALLOW_INSTANTIATION),
.slots = PySSLSession_slots,
};

Expand Down