Skip to content

gh-93896: allow enabling asyncio.Runner calls to asyncio.set_event_loop independantly to loop_factory #94058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
graingert wants to merge 13 commits into from
Closed

gh-93896: allow enabling asyncio.Runner calls to asyncio.set_event_loop independantly to loop_factory #94058

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f6b7bab
restore the set_event_loop calls to asyncio.run
graingert Jun 21, 2022
428cc8a
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 21, 2022
7786b44
test that asyncio.Runner does not touch the asyncio policy system
graingert Jun 21, 2022
abbd6b4
only check policy loop in tearDown
graingert Jun 21, 2022
d113102
Update Lib/asyncio/runners.py
graingert Jun 22, 2022
35e746f
Update Lib/unittest/async_case.py
graingert Jun 22, 2022
489d544
Merge branch 'main' into restore-set-event-loop-policy-to-asyncio-run
graingert Jun 22, 2022
9f0f519
Merge branch 'main' into restore-set-event-loop-policy-to-asyncio-run
graingert Jun 24, 2022
1431a63
Update Misc/NEWS.d/next/Library/2022-06-21-13-08-46.gh-issue-93896.2B…
graingert Jun 25, 2022
45b1af0
Merge branch 'main' into restore-set-event-loop-policy-to-asyncio-run
graingert Jun 27, 2022
28af308
Merge branch 'main' into restore-set-event-loop-policy-to-asyncio-run
graingert Jun 28, 2022
83b1514
Merge branch 'main' into restore-set-event-loop-policy-to-asyncio-run
graingert Jul 6, 2022
5865ac6
Apply suggestions from code review
graingert Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test that asyncio.Runner does not touch the asyncio policy system
  • Loading branch information
@graingert
graingert committed Jun 22, 2022
commit 7786b44539480337c6832917943229b8a298c3a4
21 changes: 20 additions & 1 deletion Lib/test/test_asyncio/test_runners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,19 @@ def set_event_loop(self, loop):
self.loop = loop


class NullPolicy(asyncio.AbstractEventLoopPolicy):

def get_event_loop(self):
# shouldn't ever be called by asyncio.run()
raise RuntimeError

def new_event_loop(self):
raise RuntimeError

def set_event_loop(self, loop):
raise RuntimeError


class BaseTest(unittest.TestCase):

def new_loop(self):
Expand All @@ -60,7 +73,7 @@ async def shutdown_asyncgens():
def setUp(self):
super().setUp()

policy = TestPolicy(self.new_loop)
policy = NullPolicy()
asyncio.set_event_loop_policy(policy)

def tearDown(self):
Expand All @@ -75,6 +88,12 @@ def tearDown(self):

class RunTests(BaseTest):

def setUp(self):
super().setUp()

policy = TestPolicy(self.new_loop)
asyncio.set_event_loop_policy(policy)

def test_asyncio_run_return(self):
async def main():
await asyncio.sleep(0)
Expand Down