Skip to content

gh-93939: Build most shared extensions without setup.py #93940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tiran wants to merge 6 commits into from
Closed

gh-93939: Build most shared extensions without setup.py #93940

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfb33e6
gh-93939: Build most shared extensions without setup.py
tiran Jun 17, 2022
0e91b39
Fix generate_stdlib_module_names script to use Makefile
tiran Jun 17, 2022
f22f837
variable has been renamed
tiran Jun 27, 2022
80894ee
blurb
tiran Jun 28, 2022
ef08a28
Improve check_modules script
tiran Jun 28, 2022
e23a5dd
Fail on failing makesetup
tiran Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
variable has been renamed
  • Loading branch information
@tiran
tiran committed Jun 29, 2022
commit f22f837e500694d8c0827414bb4d43fe92531a2d
10 changes: 3 additions & 7 deletions Tools/scripts/check_shared_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def get_makefile_modules(args: argparse.Namespace) -> list[ModuleInfo]:
MODSHARED_NAMES: modules in *shared* block
MODDISABLED_NAMES: modules in *disabled* block

Modules built by setup.py addext() have a MODULE_{modname} entry,
Modules built by setup.py addext() have a MODULE_{modname}_STATE entry,
but are not listed in MODSHARED_NAMES.

Modules built by old-style setup.py add() have neither a MODULE_{modname}
Expand All @@ -73,16 +73,12 @@ def get_makefile_modules(args: argparse.Namespace) -> list[ModuleInfo]:

modules = []
for key, value in sysconfig.get_config_vars().items():
if not key.startswith("MODULE_"):
continue
if key.endswith(
("_CFLAGS", "_DEPS", "_LDFLAGS", "_OBJS", "CTYPES_MALLOC_CLOSURE")
):
if not key.startswith("MODULE_") or not key.endswith("_STATE"):
continue
if value not in {"yes", "disabled", "n/a"}:
raise ValueError(f"Unsupported {value} for {key}")

modname = key[7:].lower()
modname = key[7:-6].lower()
is_builtin = modname in modbuiltin
if modname in moddisabled:
# Setup "*disabled*" rule
Expand Down
6 changes: 2 additions & 4 deletions Tools/scripts/generate_stdlib_module_names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,11 @@ def list_modules_setup_extensions(names):
"""Get MODULE_{modname}={yes|disabled|n/a} entries from Makefile
"""
for key, value in sysconfig.get_config_vars().items():
if not key.startswith("MODULE_"):
continue
if key.endswith(("_CFLAGS", "_DEPS", "_LDFLAGS", "_OBJS")):
if not key.startswith("MODULE_") or not key.endswith("_STATE"):
continue
if value not in {"yes", "disabled", "n/a"}:
raise ValueError(f"Unsupported {value} for {key}")
name = key[7:].lower()
name = key[7:-6].lower()
names.add(name)


Expand Down