Skip to content

test_logging: Fix BytesWarning in SysLogHandlerTest (GH-93920) #93920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 1 commit into from
Jun 17, 2022
Merged

test_logging: Fix BytesWarning in SysLogHandlerTest (GH-93920) #93920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test_logging: Fix BytesWarning in SysLogHandlerTest 
Initialize log_output to an empty byte strings to prevent the error
(when running the test with python -bb):

Traceback (most recent call last):
  File "Lib\test\test_logging.py", line 2013, in test_udp_reconnection
    self.assertEqual(self.log_output, b'<11>sp\xc3\xa4m\x00')
  (...)
BytesWarning: Comparison between bytes and string
  • Loading branch information
@vstinner
vstinner committed Jun 16, 2022
commit ec25b95909dc484b2cb7499160d765385786d9d5
2 changes: 1 addition & 1 deletion Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1965,7 +1965,7 @@ def setUp(self):
self.sl_hdlr = hcls((server.server_address[0], server.port))
else:
self.sl_hdlr = hcls(server.server_address)
self.log_output = ''
self.log_output = b''
self.root_logger.removeHandler(self.root_logger.handlers[0])
self.root_logger.addHandler(self.sl_hdlr)
self.handled = threading.Event()
Expand Down