Skip to content

gh-93911: LOAD_ATTR_PROPERTY #93912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 14 commits into from
Jun 17, 2022
Merged

gh-93911: LOAD_ATTR_PROPERTY #93912

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c9966d1
More LOAD_ATTR specializations
Fidget-Spinner Jun 16, 2022
e66782b
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 16, 2022
c7bde64
fix compiler warnings
Fidget-Spinner Jun 16, 2022
6a03dad
Fix double backticks
Fidget-Spinner Jun 16, 2022
c78831d
Apply Mark's suggestions
Fidget-Spinner Jun 16, 2022
d03cc61
try to fix compiler warnings
Fidget-Spinner Jun 16, 2022
36af644
re-enable LOAD_ATTR_CLASS_MUTABLE_DESCRIPTOR
Fidget-Spinner Jun 16, 2022
c20af47
Remove double stat count
Fidget-Spinner Jun 16, 2022
3d5d5fd
remove LOAD_ATTR_MUTABLE_CLASS_DESCRIPTOR
Fidget-Spinner Jun 16, 2022
7f45ec1
Delete 2022-06-16-08-56-26.gh-issue-93657.AZG2WT.rst
Fidget-Spinner Jun 16, 2022
a6c4ab3
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 16, 2022
626bfa1
fix up stats and deopt
Fidget-Spinner Jun 17, 2022
4786bac
Use 32 bit func_version
Fidget-Spinner Jun 17, 2022
9f32d03
remove the version check
Fidget-Spinner Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove the version check
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Jun 17, 2022
commit 9f32d037ee99f37979f5baa527076757e7962964
6 changes: 2 additions & 4 deletions Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,10 +726,8 @@ _Py_Specialize_LoadAttr(PyObject *owner, _Py_CODEUNIT *instr, PyObject *name)
goto fail;
}
int version = _PyFunction_GetVersionForCurrentState(func);
if (version == 0 || version != (uint16_t)version) {
SPECIALIZATION_FAIL(LOAD_ATTR,
version == 0 ?
SPEC_FAIL_OUT_OF_VERSIONS : SPEC_FAIL_OUT_OF_RANGE);
if (version == 0) {
SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_OUT_OF_VERSIONS);
goto fail;
}
write_u32(lm_cache->keys_version, version);
Expand Down