Skip to content

bpo-34720: Fix test_importlib.test_bad_traverse for AIX #9391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 6 commits into from
Feb 17, 2019
Merged

bpo-34720: Fix test_importlib.test_bad_traverse for AIX #9391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40ec805
Fix test_importlib.test_bad_traverse for AIX
aixtools Sep 18, 2018
05469e1
Fix whitespace
aixtools Sep 18, 2018
ce014f3
News not required
aixtools Oct 29, 2018
b7c9b9a
Assert m_state != NULL to mimic transversal functions that do not cor…
aixtools Dec 26, 2018
4a1215b
Tweak NEWS entry wording.
ncoghlan Feb 17, 2019
739b9a8
Add comment explaining why the assert() is OK
ncoghlan Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2018-12-26-12-31-16.bpo-34720.T268vz.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Assert m_state != NULL to mimic GC traversal functions that do not correctly
handle module creation when the module state has not been created.
8 changes: 8 additions & 0 deletions Modules/_testmultiphase.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,14 @@ bad_traverse(PyObject *self, visitproc visit, void *arg) {
testmultiphase_state *m_state;

m_state = PyModule_GetState(self);

/* The following assertion mimics any traversal function that doesn't correctly handle
* the case during module creation where the module state hasn't been created yet.
*
* The check that it is used to test only runs in debug mode, so it is OK that the
* assert() will get compiled out in fully optimised release builds.
*/
assert(m_state != NULL);
Py_VISIT(m_state->integer);
return 0;
}
Expand Down