Skip to content

gh-93851: Add Tools/scripts/checkhtmllinks.py #93856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arhadthedev wants to merge 8 commits into from
Closed

gh-93851: Add Tools/scripts/checkhtmllinks.py #93856

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8f0661d
Initial revision of Tools/scripts/checkhtmllinks.py
arhadthedev Jun 14, 2022
a547a73
Clarify runtime estimations
arhadthedev Jun 14, 2022
5a9e8d8
Hide an unimportant abstraction
arhadthedev Jun 15, 2022
c57e264
Use more relevant abstractions
arhadthedev Jun 15, 2022
9c4ab0f
Use the same capitalization as in `-h` cmdline key
arhadthedev Jun 15, 2022
0911e9d
Merge branch 'main' into script-checkhtml
arhadthedev Jul 21, 2022
af53ada
Fix test_target() so it always returns a list
arhadthedev Aug 4, 2022
937a72c
Merge branch 'main' into script-checkhtml
arhadthedev Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Hide an unimportant abstraction
  • Loading branch information
@arhadthedev
arhadthedev committed Jun 15, 2022
commit 5a9e8d86aaab522114d6e76f15a205ab998695f2
15 changes: 7 additions & 8 deletions Tools/scripts/checkhtmllinks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@
from urllib.response import addinfourl


def get_attribute(attribute_name: str, container: list[tuple[str, str]]):
"""Scan a list of (name, value) tuples collecting requested values."""
return (value for name, value in container if name == attribute_name)


class LinkAnalyzer(HTMLParser):
"""Scanner for hyperlink referers and targets.

Expand All @@ -44,11 +39,15 @@ def __init__(self):
self.targets = set()
self.referers = set()

@staticmethod
def _get_attribute(attribute_name: str, container: list[tuple[str, str]]):
return (value for name, value in container if name == attribute_name)

def handle_starttag(self, tag, attrs):
if tag == 'a':
self.referers.update(get_attribute('href', attrs))
self.targets.update(get_attribute('name', attrs))
self.targets.update(get_attribute('id', attrs))
self.referers.update(self._get_attribute('href', attrs))
self.targets.update(self._get_attribute('name', attrs))
self.targets.update(self._get_attribute('id', attrs))


class _NoRedirectHandler(HTTPRedirectHandler):
Expand Down