Skip to content

gh-93851: Fix all broken links in Doc/ #93853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 11 commits into from
Jun 21, 2022
Merged

gh-93851: Fix all broken links in Doc/ #93853

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d34731f
Fix all broken links in Doc/
arhadthedev Jun 15, 2022
9a20620
Fix line ends
arhadthedev Jun 15, 2022
bd5d3d2
Add a living link to setuptool entry points
arhadthedev Jun 15, 2022
c8fa76e
Return lists.idyll.org link back
arhadthedev Jun 15, 2022
e895a5f
Address Ned's review
arhadthedev Jun 16, 2022
877513b
Copy a comment by Ned into the code
arhadthedev Jun 16, 2022
17aa611
Use tags instead of commit hashes
arhadthedev Jun 16, 2022
6cdf99a
Fix a typo
arhadthedev Jun 16, 2022
73ae702
Use Jinja comments instead of the Liquid ones
arhadthedev Jun 16, 2022
9f6ced4
Merge branch 'main' into fix-doc-links
arhadthedev Jun 16, 2022
8665a44
Use HTTPS for Web Archive links
arhadthedev Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a typo
  • Loading branch information
@arhadthedev
arhadthedev committed Jun 16, 2022
commit 6cdf99ab7791a10d23d88524b334e70796553557
2 changes: 1 addition & 1 deletion Doc/whatsnew/3.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2594,7 +2594,7 @@ Changes to Python's build process and to the C API include:

There were a number of other small changes to the C-API. See the
Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_
Copy link
Copy Markdown
Member Author

@arhadthedev arhadthedev Jun 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_
`Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_

For some reason, gh-94078 backport is the only one that caught this typo.

Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly because it was using the old docs checker script as opposed to Sphinx-Lint. Could you verify whether the latest Sphinx-Lint 0.6.6 catches this case, and if not, could you report it upstream? Thanks!

Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it really isn't great that we're regressing from using a dedicated role to hardcoded links...but hopefully the new suite of roles we're developing for this will replace this.

Copy link
Copy Markdown
Member Author

@arhadthedev arhadthedev Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you verify whether the latest Sphinx-Lint 0.6.6 catches this case [...]

I ran sphinx-lint 0.6.7 and it caught the typo successfully:

C:\Users\oleg\Documents\dev\notmine\cpython>sphinx-lint Doc/whatsnew/3.2.rst
Doc/whatsnew/3.2.rst:54: missing backtick before hyperlink reference: 'Misc/NEWS <https://github.com/python/cpython/blob/v3.2.6/Misc/NEWS>`_'. (hyperlink-reference-missing-backtick)

So I hope that adoption of sphinx-lint will eliminate such sporadic discoveries.

\file for a complete list.
file for a complete list.

Also, there were a number of updates to the Mac OS X build, see
`Mac/BuildScript/README.txt <https://github.com/python/cpython/blob/v3.2.6/Mac/BuildScript/README.txt>`_
Expand Down