-
Notifications
You must be signed in to change notification settings - Fork 35.4k
gh-83638: Add sqlite3.Connection.autocommit for PEP 249 compliant behaviour #93823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erlend-aasland
merged 82 commits into
python:main
from
erlend-aasland:sqlite-autocommit
Nov 12, 2022
Merged
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
10d3a65
Add sqlite3.Connection.autocommit for PEP 249 compliant behaviour
6ca9045
Add basic tests
5772676
Add documentation
06609f3
Add NEWS
8b6b866
Add What's New
a604a57
Document DEPRECATED_TRANSACTION_CONTROL
cbc1041
Fix setattr behaviour
41b898c
Suggest new behaviour starting with Python 3.14
b11ebd2
Simplify implicit rollback test
d3009d4
Address Alex' review
fb98615
Reorder if condition to add emphasis to deprecated behaviour
5e4626e
Add context manager tests
a8e3b9e
Improve 5e4626ecf47a679ba5fa8846472af16fb325cac5
d46e9be
Add executescript tests
c2e2f1a
Improve docs
3bf3ee1
Add missing versionadded
757f70b
Try to further improve the docs
a5ef40c
Nano-optimisation
ae37fbb
Explicit downcast
341e0dd
Clarify execute*, commit, rollback, and close
77651c0
Incorporate gh-93890 changes
0ac782c
Improve
7743f34
Merge branch 'main' into sqlite-autocommit
6628e30
commit/rollback wordings
060bd3a
Fix merge
c96adbf
Doc: reword context manager section
a7c7c4c
Autocommit is keyword only
f1c5843
Isolation level is not yet deprecated (soon it will be though)
491426e
Merge remote-tracking branch 'upstream/main' into sqlite-autocommit
05879a9
Merge branch 'main' into sqlite-autocommit
97ad734
Use macro as C default
bf3a857
Merge branch 'main' into sqlite-autocommit
60f7224
Merge branch 'main' into sqlite-autocommit
7f645ee
Pass keywords to factory function
88fb2b9
Merge branch 'main' into sqlite-autocommit
4deed17
Adjust commit/rollback and remove redundant info
f3a9e37
Merge branch 'main' into sqlite-autocommit
2981a6b
Fix docstring
a5b7864
Revert unneeded doc changes
fd6659a
Fix autocommit enum
52e3736
Sync with main bco. recent doc updates
6e92073
Merge branch 'main' into sqlite-autocommit
59fbd29
Merge branch 'main' into sqlite-autocommit
894fcce
Add autocommit to connect signature
fff4307
Merge branch 'main' into sqlite-autocommit
4ac0fa0
Address Alex's second review
64c6482
Adjust headings
e4947d0
Use versionadded iso. versionchanged
5981536
Remove some no-ops
527e6a3
Three adjustments:
697b65a
Address Alex's last round of review
4299874
Sync with main bco. recent Argument Clinic changes
76122be
Regen all
6902738
Explicit logic in set_autocommit
c37ebb5
Tweak naming: connection_txn_stmt => connection_exec_stmt
2e9083c
Merge branch 'main' into sqlite-autocommit
b944a90
Address review: improve wording for connection close()
bce921f
Sync with main
78e04f0
Fix bad merge
bd91e34
Remove implicit commit for cx.autocommit = False
9d66daa
Doc: make the autocommit reference more to the point; expand in the e…
d4c0583
Address most of CAM's review
a3aa9aa
Better naming for the constant; don't mention deprecations (yet)
c9b05ff
Fix default role
d5e33f1
Make it explicit that isolation_level is ignored if autocommit is Tru…
0cf022a
Reflow
5009372
Address review: COMPAT_TRANSACTIONAL_CONTROL => LEGACY_TRANSACTION_CO…
2c9b117
Address more of CAM's review
de3bd4e
Try to address the rest of CAM's review
fca9c56
Sync with main
7de6bf3
Address more of CAM's remarks
e0fa134
Prevent segfault if implicitly rolling back during interpreter shutdown
e0bedf6
Update Doc/library/sqlite3.rst
e33946a
Address last batch of CAM's comments
cd15505
Last bit
4feefa1
Update Doc/library/sqlite3.rst
720ac11
Sync with main
f7c2ae4
Update Doc/library/sqlite3.rst
88e1420
Sync with main
7b87830
Address review: remove unneeded assert in test_autocommit_setget_invalid
8322683
Address review: add test for rollback() if autocommit is True
aca1e22
Address review: fixup context manager docs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Reflow
- Loading branch information
commit 0cf022a27dd2eb02e74d37361531ab234b3cf264
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.