Skip to content

[3.10] gh-79579: Improve DML query detection in sqlite3 (GH-93623) #93801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 3 commits into from
Jun 14, 2022
Merged

[3.10] gh-79579: Improve DML query detection in sqlite3 (GH-93623) #93801

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84423c9
[3.10] gh-79579: Improve DML query detection in sqlite3 (GH-93623)
erlend-aasland Jun 14, 2022
a2f3acb
Update statement.c
Jun 14, 2022
2f29880
Update statement.c
Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[3.10] gh-79579: Improve DML query detection in sqlite3 (GH-93623) 
The fix involves using pysqlite_check_remaining_sql(), not only to check
for multiple statements, but now also to strip leading comments and
whitespace from SQL statements, so we can improve DML query detection.

pysqlite_check_remaining_sql() is renamed lstrip_sql(), to more
accurately reflect its function, and hardened to handle more SQL comment
corner cases..
(cherry picked from commit 4674007)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jun 14, 2022
commit 84423c916c9e7e1474ba0e39a4ef3b9f1bce25b8
Loading