Skip to content

gh-93692: remove redundant "build finished successfully" message from setup.py #93693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 3 commits into from
Jun 24, 2022
Merged

gh-93692: remove redundant "build finished successfully" message from setup.py #93693

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9303c4
gh-93692: setup.py now reports successful builds if the build succeeded
erlend-aasland Jun 10, 2022
7d0da85
Merge branch 'main' into build-succeeded
erlend-aasland Jun 23, 2022
1d79898
Just remove the message
erlend-aasland Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-93692: setup.py now reports successful builds if the build succeeded
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jun 10, 2022
commit d9303c44305c72e3df4548a7fcea11f7e83b7ecd
6 changes: 5 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,9 +536,13 @@ def print_three_column(lst):
print("%-*s %-*s %-*s" % (longest, e, longest, f,
longest, g))

if self.missing:
if not self.failed:
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
print()
print("Python build finished successfully!")
print()

if self.missing:
print()
print("The necessary bits to build these optional modules were not "
"found:")
print_three_column(self.missing)
Expand Down