Skip to content

gh-93548: Add an example of SASL PLAIN authentication to documentation#93549

Closed
JulienFS wants to merge 9 commits into
python:mainfrom
JulienFS:fix-utf8_imap_password
Closed

gh-93548: Add an example of SASL PLAIN authentication to documentation#93549
JulienFS wants to merge 9 commits into
python:mainfrom
JulienFS:fix-utf8_imap_password

Conversation

@JulienFS

@JulienFS JulienFS commented Jun 6, 2022

Copy link
Copy Markdown

@JulienFS JulienFS requested a review from a team as a code owner June 6, 2022 17:11
@ghost

ghost commented Jun 6, 2022

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@JulienFS

JulienFS commented Jun 6, 2022

Copy link
Copy Markdown
Author

It seems that the specifications explicitly forbid the use of ENABLE before auth :

The ENABLE command is only valid in the authenticated state, before any mailbox is selected.

Maybe the login phase should handle UTF8 natively though :

Characters are 8-bit UTF-8 (of which 7-bit US-ASCII is a subset), unless otherwise specified.

EDIT: defaulting to UTF-8 is an IMAP4Rev2 thing. But it looks like some servers advertising rev1 are supporting utf-8.

@JulienFS

JulienFS commented Jun 6, 2022

Copy link
Copy Markdown
Author

OK I feel silly, it looks like everybody is using AUTHENTICATE to bypass the UTF-8 limit and I was not aware of this. I'll revert my changes and update the documentation with a plain auth example.

@AA-Turner AA-Turner added type-bug An unexpected behavior, bug, or error topic-email labels Jun 6, 2022
@JulienFS JulienFS changed the title gh-93548: allow ENABLE command in NONAUTH state in imaplib gh-93548: add exemple of SASL PLAIN authentication in documentation Jun 7, 2022
@JulienFS JulienFS force-pushed the fix-utf8_imap_password branch from 96ce887 to 11f7124 Compare January 10, 2023 08:42
@arhadthedev arhadthedev changed the title gh-93548: add exemple of SASL PLAIN authentication in documentation gh-93548: add example of SASL PLAIN authentication to documentation Feb 16, 2023
@arhadthedev arhadthedev changed the title gh-93548: add example of SASL PLAIN authentication to documentation gh-93548: Add an example of SASL PLAIN authentication to documentation Feb 16, 2023
@bedevere-bot

This comment was marked as outdated.

@arhadthedev arhadthedev added docs Documentation in the Doc dir skip news labels Feb 16, 2023
@arhadthedev

Copy link
Copy Markdown
Member

@python/email-team ping

@JulienFS

Copy link
Copy Markdown
Author

This PR is dead de facto.

@JulienFS JulienFS closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news topic-email type-bug An unexpected behavior, bug, or error

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants