Skip to content

GH-93521: Filter out __weakref__ slot if present in bases #93535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericvsmith merged 4 commits into from
Jun 8, 2022
+61 −4
Merged

GH-93521: Filter out __weakref__ slot if present in bases #93535

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abdab30
GH-93521: Filter out `__weakref__` slot if present in bases
Bluenix2 Jun 6, 2022
5ee1d76
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 6, 2022
47a107f
Expand test coverage of subclasses specifying `__weakref__`
Bluenix2 Jun 6, 2022
187a0fe
Reword news blurb to explain change without context
Bluenix2 Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reword news blurb to explain change without context
  • Loading branch information
@Bluenix2
Bluenix2 committed Jun 6, 2022
commit 187a0fef6f661e8491b8e099ccd639ad5a48c79a
5 changes: 4 additions & 1 deletion Misc/NEWS.d/next/Library/2022-06-06-13-19-43.gh-issue-93521._vE8m9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
Allow specifying ``weakref_slot`` several times in dataclass MRO
Fixed a case where dataclasses would try to add ``__weakref__`` into the
``__slots__`` for a dataclass that specified ``weakref_slot=True`` when it was
already defined in one of its bases. This resulted in a ``TypeError`` upon the
new class being created.