Skip to content

gh-93421: Update sqlite3 cursor.rowcount after SQLITE_DONE #93526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 9 commits into from
Jun 8, 2022
Merged

gh-93421: Update sqlite3 cursor.rowcount after SQLITE_DONE #93526

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bb4062a
Update rowcount after SQLITE_DONE
erlend-aasland Jun 5, 2022
ce12c96
Harden executemany check
erlend-aasland Jun 6, 2022
9e44c0c
Merge branch 'main' into sqlite-changes-alt
erlend-aasland Jun 6, 2022
b66adaf
Use 64-bit API if available
erlend-aasland Jun 6, 2022
731dfc5
Adjust NEWS
erlend-aasland Jun 6, 2022
ef10d9e
Merge branch 'main' into sqlite-changes-alt
erlend-aasland Jun 8, 2022
02bd83f
Revert 64-bit API support
erlend-aasland Jun 8, 2022
b75b725
Refactor
erlend-aasland Jun 8, 2022
0ebf8a8
Doh, reset _after_ fetching changes
erlend-aasland Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Harden executemany check
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jun 6, 2022
commit ce12c963ae00388d6a34bb3236b7590d6018566f
2 changes: 1 addition & 1 deletion Modules/_sqlite/cursor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,7 +944,7 @@ _pysqlite_query_execute(pysqlite_Cursor* self, int multiple, PyObject* operation
}
}

if (self->statement->is_dml && multiple) {
if (self->statement->is_dml && rc == SQLITE_DONE && multiple) {
self->rowcount += (long)sqlite3_changes(self->connection->db);
}

Expand Down