Skip to content

gh-93491: Add support tier detection to configure (GH-93492) #93492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiran merged 9 commits into from
Jun 10, 2022
Merged

gh-93491: Add support tier detection to configure (GH-93492) #93492

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
823b0b2
gh-93491: Add support tier detection to configure
tiran Mar 24, 2022
28fc007
Fix markup
tiran Jun 4, 2022
4629e38
Apply suggestions from code review
tiran Jun 4, 2022
b2e7ba4
regen configure
tiran Jun 4, 2022
7d9d6e7
Update PC/pyconfig.h
tiran Jun 7, 2022
8c75681
Use AC_MSG_WARN for tier 0
tiran Jun 10, 2022
63cb7f6
regen configure
tiran Jun 10, 2022
3132f21
not yet
tiran Jun 10, 2022
228082e
regen configure
tiran Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use AC_MSG_WARN for tier 0 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
  • Loading branch information
@tiran @erlend-aasland
tiran and erlend-aasland committed Jun 10, 2022
commit 8c756811a79a40b8735c7265db10d30f8f9647f1
4 changes: 2 additions & 2 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,7 @@ AS_CASE([$PY_SUPPORT_TIER],
[1], [AC_MSG_RESULT([$host/$ac_cv_cc_name has tier 1 (supported)])],
[2], [AC_MSG_RESULT([$host/$ac_cv_cc_name has tier 2 (supported)])],
[3], [AC_MSG_RESULT([$host/$ac_cv_cc_name has tier 3 (partially supported)])],
[AC_MSG_RESULT([$host/$ac_cv_cc_name is not supported])]
[AC_MSG_WARN([$host/$ac_cv_cc_name is not supported])]
)

AC_DEFINE_UNQUOTED([PY_SUPPORT_TIER], [$PY_SUPPORT_TIER], [PEP 11 Support tier (1, 2, 3 or 0 for unsupported)])
Expand Down Expand Up @@ -6944,7 +6944,7 @@ please run ./configure --enable-optimizations
])
fi

AS_VAR_IF([PY_SUPPORT_TIER], [0], [AC_MSG_NOTICE([
AS_VAR_IF([PY_SUPPORT_TIER], [0], [AC_MSG_WARN([

Platform "$host" with compiler "$ac_cv_cc_name" is not yet supported by the
Comment thread
tiran marked this conversation as resolved.
Outdated
CPython core team, see https://peps.python.org/pep-0011/ for more information.
Expand Down