Skip to content

gh-93370 : Deprecate sqlite3.version and sqlite3.version_info #93482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 29 commits into from
Jun 7, 2022
Merged

gh-93370 : Deprecate sqlite3.version and sqlite3.version_info #93482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
5debfa5
remove version and version_info from sqlite3
rawwar Jun 3, 2022
c648144
Merge branch 'python:main' into fix-issue-93370
rawwar Jun 3, 2022
ee0cec7
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 3, 2022
69e7410
used __getattr__ to raise warnings
rawwar Jun 3, 2022
6c2a8c8
removed repeated declaration
rawwar Jun 3, 2022
459a94c
including feedback
rawwar Jun 4, 2022
4a55ef3
move declaration to the start of the module
rawwar Jun 4, 2022
1a75e5f
fixed formatting issues
rawwar Jun 4, 2022
8584a03
extra lines removed
rawwar Jun 4, 2022
fa80dd6
Update Lib/sqlite3/__init__.py
rawwar Jun 4, 2022
f47ddf3
Update Lib/sqlite3/dbapi2.py
rawwar Jun 4, 2022
f033aea
Update Lib/sqlite3/dbapi2.py
rawwar Jun 4, 2022
49ea9e1
updated docs
rawwar Jun 4, 2022
451e9ef
Update Lib/sqlite3/__init__.py
rawwar Jun 4, 2022
591f2b9
Update Lib/sqlite3/dbapi2.py
rawwar Jun 4, 2022
3f4e967
Apply suggestions from code review
rawwar Jun 4, 2022
d70b247
update blurb with correct ref
rawwar Jun 4, 2022
ed50588
included my name in ACKS
rawwar Jun 4, 2022
8f06e31
Update Doc/library/sqlite3.rst
rawwar Jun 4, 2022
836cddf
adding tests for version and version_info deprec
rawwar Jun 4, 2022
2102bf0
added dbapi2 tests and updated docs
rawwar Jun 4, 2022
04dad03
use mod sqlite3 in sqlite3 doc
rawwar Jun 4, 2022
81cf7fa
Update Doc/library/sqlite3.rst
erlend-aasland Jun 5, 2022
964cf86
Update Doc/library/sqlite3.rst
erlend-aasland Jun 5, 2022
f00b352
added assertIn and assertEqual in tests
rawwar Jun 7, 2022
1920746
using assertEqual
rawwar Jun 7, 2022
46922f6
removed white space
rawwar Jun 7, 2022
45478cc
Apply suggestions from code review
rawwar Jun 7, 2022
bc7b463
Update Lib/test/test_sqlite3/test_dbapi.py
erlend-aasland Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move declaration to the start of the module
  • Loading branch information
@rawwar
rawwar committed Jun 4, 2022
commit 4a55ef3a30e86805db197b598ee0a7635cb05adf
1 change: 0 additions & 1 deletion Lib/sqlite3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
_deprecated_version)

def __getattr__(name):

if name in _deprecated_names:
from warnings import warn
warn(f"{name} is deprecated. Will be removed in python 3.14", DeprecationWarning, stacklevel=2)
Expand Down
3 changes: 2 additions & 1 deletion Lib/sqlite3/dbapi2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
from _sqlite3 import *
from _sqlite3 import _deprecated_version

_deprecated_names = ["version", "version_info"]
Comment thread
rawwar marked this conversation as resolved.
Outdated

paramstyle = "qmark"

apilevel = "2.0"
Expand Down Expand Up @@ -87,7 +89,6 @@ def convert_timestamp(val):

del(register_adapters_and_converters)

_deprecated_names = ["version", "version_info"]

def __getattr__(name):
if name in _deprecated_names:
Expand Down