Skip to content

gh-93476: Fraction.limit_denominator speed increase #93477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mscuthbert wants to merge 7 commits into from
Closed

gh-93476: Fraction.limit_denominator speed increase #93477

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
599c55b
gh-93476: Fraction.limit_denominator speed increases
mscuthbert Jun 3, 2022
70ca7ad
add NEWS.d item
mscuthbert Jun 3, 2022
a1a4fc8
Fix boundary case.
mscuthbert Jun 4, 2022
3c06ded
Review comments
mscuthbert Jun 5, 2022
e5ab32e
trailing space
mscuthbert Jun 5, 2022
40cbe78
return Fraction(self) for limit case
mscuthbert Jun 5, 2022
f5daa21
drop comment for now. can be separate PR
mscuthbert Jun 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
trailing space
  • Loading branch information
@mscuthbert
mscuthbert committed Jun 5, 2022
commit e5ab32ec49c8d329e1bdfe90eec2bb77a67b9e77
2 changes: 1 addition & 1 deletion Lib/fractions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def limit_denominator(self, max_denominator=1000000):
bound2_n = p1
bound2_d = q1
Comment thread
mscuthbert marked this conversation as resolved.

# diff1_n = numerator of (bound1 minus self) as a Fraction;
# diff1_n = numerator of (bound1 minus self) as a Fraction;
# etc. for diff1_d, diff2_n, diff2_d
diff1_n = abs(bound1_n*d_original - n_original*bound1_d)
diff1_d = d_original * bound1_d
Expand Down