Skip to content

[2.7] bpo-34603, ctypes/libffi_msvc: Fix returning structs from functions (GH-9258)#9342

Closed
miss-islington wants to merge 1 commit into
python:2.7from
miss-islington:backport-7843cae-2.7
Closed

[2.7] bpo-34603, ctypes/libffi_msvc: Fix returning structs from functions (GH-9258)#9342
miss-islington wants to merge 1 commit into
python:2.7from
miss-islington:backport-7843cae-2.7

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 16, 2018

Copy link
Copy Markdown
Contributor

(cherry picked from commit 7843cae)

Co-authored-by: Vladimir Matveev v2matveev@outlook.com

https://bugs.python.org/issue34603

…ythonGH-9258)

(cherry picked from commit 7843cae)

Co-authored-by: Vladimir Matveev <v2matveev@outlook.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vladima and @vstinner: Status check is done, and it's a failure ❌ .

@vstinner

Copy link
Copy Markdown
Member

@vladima: Oh, the backport just fails because the test uses f-string. Can you try to backport your change manually and create a new PR? See for example https://devguide.python.org/gitbootcamp/#backporting-merged-changes

@vladima

vladima commented Sep 19, 2018

Copy link
Copy Markdown
Contributor

@vstinner I can definitely do that :)

@vstinner

Copy link
Copy Markdown
Member

I merged PR #9425.

@vstinner vstinner closed this Sep 19, 2018
@miss-islington miss-islington deleted the backport-7843cae-2.7 branch September 19, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants