Skip to content

gh-92592: Allow logging filters to return a LogRecord. (GH-92591) #92591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 18 commits into from
Jun 7, 2022
Merged

gh-92592: Allow logging filters to return a LogRecord. (GH-92591) #92591

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3aeeba6
allow logging filters to return a LogRecord
adriangb May 10, 2022
1e4d27f
edit docstring
adriangb May 10, 2022
b526a35
remove unecessary __bool__ impl
adriangb May 10, 2022
f1ea183
edit docs
adriangb May 10, 2022
19561d3
Add docs and blurb
adriangb May 10, 2022
14e704d
Merge branch 'main' into logging-filters
adriangb May 10, 2022
4d34540
fix rst
adriangb May 10, 2022
a69e76a
touch up wording
adriangb May 10, 2022
67453f6
add test for filters on loggers
adriangb May 10, 2022
b1e1084
push straggler change
adriangb May 10, 2022
f72c594
Merge branch 'main' into logging-filters
adriangb May 10, 2022
225329f
pr feedback
adriangb May 10, 2022
735d78a
Merge branch 'logging-filters' of https://github.com/adriangb/cpython…
adriangb May 10, 2022
5e54c77
Merge branch 'main' into logging-filters
adriangb May 10, 2022
f52e404
fix whitespace
adriangb May 10, 2022
46e2f7f
fix docs as per pr feedback
adriangb May 10, 2022
7a0f470
Update logging-cookbook.rst
vsajip Jun 7, 2022
643551d
Update logging.rst
vsajip Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update logging.rst
  • Loading branch information
@vsajip
vsajip authored Jun 7, 2022
commit 643551d9c502c458caf3c99a0fae0cfc79be65cf
2 changes: 1 addition & 1 deletion Doc/library/logging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ which has a ``filter`` method with the same semantics.
.. versionchanged:: 3.12
You can now return a :class:`LogRecord` instance from filters to replace
the log record rather than modifying it in place. This allows filters attached to
a :class:`Handler` to modify the log record before it is emitted without
a :class:`Handler` to modify the log record before it is emitted, without
having side effects on other handlers.

Although filters are used primarily to filter records based on more
Expand Down