Skip to content

closes bpo-34652: Always disable lchmod on Linux.#9234

Merged
benjaminp merged 2 commits into
masterfrom
benjamin-lchmod
Sep 12, 2018
Merged

closes bpo-34652: Always disable lchmod on Linux.#9234
benjaminp merged 2 commits into
masterfrom
benjamin-lchmod

Conversation

@benjaminp
Copy link
Copy Markdown
Contributor

@benjaminp benjaminp commented Sep 12, 2018 •
edited by bedevere-bot
Loading

Symbolic link modes cannot be changed on Linux, so there's no point ever trying to use this function.

https://bugs.python.org/issue34652

@benjaminp
bpo-34652: Always disable lchmod on Linux.
b780e1e 
Symbolic link modes cannot be changed on Linux, so there's no point ever trying to use this function.
Arfrever
Arfrever reviewed Sep 12, 2018
View reviewed changes
Comment thread configure.ac Outdated
@benjaminp benjaminp merged commit 40caa05 into master Sep 12, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 12, 2018

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@benjaminp benjaminp deleted the benjamin-lchmod branch September 12, 2018 22:52
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2018
@benjaminp @miss-islington
closes bpo-34652: Always disable lchmod on Linux. (pythonGH-9234)
a3bb9e7 
(cherry picked from commit 40caa05)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 12, 2018

GH-9239 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2018
@benjaminp @miss-islington
closes bpo-34652: Always disable lchmod on Linux. (pythonGH-9234)
ec4c67b 
(cherry picked from commit 40caa05)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 12, 2018

GH-9240 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 12, 2018

Sorry, @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 40caa05fa4d1810a1a6bfc34e0ec930c351089b7 2.7

benjaminp added a commit that referenced this pull request Sep 12, 2018
@benjaminp
Revert "closes bpo-34652: Always disable lchmod on Linux. (GH-9234)"
a535bc6 
This reverts commit 40caa05.
@benjaminp benjaminp mentioned this pull request Sep 12, 2018
Closed
benjaminp added a commit that referenced this pull request Sep 12, 2018
@benjaminp
[2.7] closes bpo-34652: Always disable lchmod on Linux. (GH-9234).
f8787cf 
(cherry picked from commit 40caa05)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 12, 2018

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 12, 2018

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2018
@benjaminp @miss-islington
closes bpo-34652: Always disable lchmod on Linux. (pythonGH-9234)
883702e 
(cherry picked from commit 40caa05)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 12, 2018

GH-9243 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2018
@benjaminp @miss-islington
closes bpo-34652: Always disable lchmod on Linux. (pythonGH-9234)
bfc4755 
(cherry picked from commit 40caa05)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 12, 2018

GH-9244 is a backport of this pull request to the 3.6 branch.

Arfrever
Arfrever reviewed Sep 12, 2018
View reviewed changes
Comment thread configure.ac
if test "$MACHDEP" = linux; then
undef HAVE_LCHMOD
if test "$MACHDEP" != linux; then
AC_CHECK_FUNC(lchmod)
Copy link
Copy Markdown
Contributor

@Arfrever Arfrever Sep 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you should drop lchmod from the call to AC_CHECK_FUNCS above...

miss-islington added a commit that referenced this pull request Sep 12, 2018
@miss-islington @benjaminp
closes bpo-34652: Always disable lchmod on Linux. (GH-9234)
98344a4 
(cherry picked from commit 40caa05)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington added a commit that referenced this pull request Sep 12, 2018
@miss-islington @benjaminp
closes bpo-34652: Always disable lchmod on Linux. (GH-9234)
bdace2e 
(cherry picked from commit 40caa05)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@c0d3h4x0r
Copy link
Copy Markdown

c0d3h4x0r commented Aug 29, 2019

It looks like this did not backport correctly to 2.7.x, because 2.7.16 (which lists this issue as being fixed) refuses to surface os.lchmod on OSX at all, whereas 2.7.15 surfaces it just fine (as expected on OSX). The absence of os.lchmod from 2.7.16 for MacOS is breaking scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Arfrever Arfrever Arfrever left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminp benjaminp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@benjaminp @miss-islington @bedevere-bot @c0d3h4x0r @Arfrever @the-knights-who-say-ni