Hi, @brettcannon and @serhiy-storchaka, as both of you had reviewed the original PR that this one references; would one of you be able to look at this follow-up?

The problem is that it makes all parameters optional. ExtensionFileLoader() is now valid.

I'm not familiar enough with the environment, but would that be an issue? It's not ideal but I currently see ExtensionFileLoader() as not a very useful invocation but not necessarily a breaking change - however, I might be missing something.

Alternatively, we could raise a TypeError if name and fullname are both None, with some message stating that fullname must be nonempty (presumably because if both are empty then we should only suggest passing in the non-deprecated parameter).

Something like this:

    def __init__(self, fullname=None, path=None, *, name=None):
        if name is not None:
            _warnings.warn("the 'name' parameter is deprecated; use "
                           "'fullname' instead", DeprecationWarning,
                           stacklevel=2)
            if fullname is not None:
                raise TypeError("'name' and 'fullname' cannot be used "
                                "simultaneously")
            self.name = name
        elif fullname is not None:
            self.name = fullname
        else:
            raise TypeError("'fullname' cannot be empty")
        self.path = path

There are two caveats that immediately come to mind. The first is that would name/fullname being None ever be a valid invocation? Second, this now stops ExtensionFileLoader(), but still allows it to not pass a path.

With that being said if it doesn't break anything I'm still leaning towards allowing ExtensionFileLoader().

I actually just closed the issue and all other PRs due to too much time having passed since I opened the original issue back in 2017. The risk of breaking code is too high now just to get some purity around name consistency.

@achhina thanks so much for taking a stab at this! But I'm afraid that I don't think we can take the PR.