gh-84459: Make wording more specific for Path.replace - #91853
Merged
Conversation
Member
|
/cc @barneygale |
barneygale
requested changes
Apr 26, 2022
barneygale
left a comment
Contributor
There was a problem hiding this comment.
Could you also correct the docs for os.replace()? They're wrong in a slightly different way. Otherwise LGTM.
Contributor
Author
|
Used |
barneygale
approved these changes
Apr 27, 2022
brettcannon
approved these changes
Apr 27, 2022
Contributor
|
Thanks @slateny for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Thanks @slateny for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 27, 2022
…-91853) pythonGH-84459 (cherry picked from commit 161dff7) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
|
GH-92002 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 27, 2022
…-91853) pythonGH-84459 (cherry picked from commit 161dff7) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
|
GH-92003 is a backport of this pull request to the 3.10 branch. |
Member
|
Thanks! |
miss-islington
added a commit
that referenced
this pull request
Apr 27, 2022
miss-islington
added a commit
that referenced
this pull request
Apr 27, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…-91853) pythonGH-84459 (cherry picked from commit 161dff7) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#84459
Automerge-Triggered-By: GH:brettcannon