Skip to content

Make environment change warnings always verbose. #91674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gpshead wants to merge 3 commits into from
Closed

Make environment change warnings always verbose. #91674

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fe9002
Make environment change warnings always verbose.
gpshead Apr 18, 2022
ba75122
wild goose chase... compare before and after ident
gpshead Apr 18, 2022
bdf0bb6
typo
gpshead Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make environment change warnings always verbose. 
not to be submitted, just for debugging what's up in 3.10 CI.
  • Loading branch information
@gpshead
gpshead committed Apr 18, 2022
commit 0fe900258a52cf204856fcfdfd5ee965a7b701af
9 changes: 5 additions & 4 deletions Lib/test/libregrtest/save_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,9 @@ def __exit__(self, exc_type, exc_val, exc_tb):
if current != original:
support.environment_altered = True
restore(original)
if not self.quiet and not self.pgo:
print_warning(f"{name} was modified by {self.testname}")
print(f" Before: {original}\n After: {current} ",
file=sys.stderr, flush=True)
if not self.pgo:
print_warning(
f"{name} was modified by {self.testname}\n"
f" Before: {original}\n"
f" After: {current} ")
return False