Skip to content

gh-91401: Add a failsafe way to disable vfork. #91490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 5 commits into from
Apr 25, 2022
Merged

gh-91401: Add a failsafe way to disable vfork. #91490

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aba06a0
gh-91401: Add a failsafe way to disable vfork.
gpshead Apr 12, 2022
c99fb75
Switch the attr name to _USE_VFORK for consistency
gpshead Apr 25, 2022
b794394
Add a comment, default to True.
gpshead Apr 25, 2022
9154ad8
NEWS entry.
gpshead Apr 25, 2022
9272669
Add a unittest for _USE_VFORK.
gpshead Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add a unittest for _USE_VFORK.
  • Loading branch information
@gpshead
gpshead committed Apr 25, 2022
commit 9272669fd31c4bfaa56fc2d1c80599b463ab3820
16 changes: 16 additions & 0 deletions Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,6 +1543,22 @@ def test_class_getitems(self):
self.assertIsInstance(subprocess.Popen[bytes], types.GenericAlias)
self.assertIsInstance(subprocess.CompletedProcess[str], types.GenericAlias)

@unittest.skipIf(not sysconfig.get_config_var("HAVE_VFORK"),
"vfork() not enabled by configure.")
@mock.patch("subprocess._fork_exec")
def test__use_vfork(self, mock_fork_exec):
self.assertTrue(subprocess._USE_VFORK) # The default value regardless.
mock_fork_exec.side_effect = RuntimeError("just testing args")
with self.assertRaises(RuntimeError):
subprocess.run([sys.executable, "-c", "pass"])
mock_fork_exec.assert_called_once()
self.assertTrue(mock_fork_exec.call_args.args[-1])
with mock.patch.object(subprocess, '_USE_VFORK', False):
with self.assertRaises(RuntimeError):
subprocess.run([sys.executable, "-c", "pass"])
self.assertFalse(mock_fork_exec.call_args_list[-1].args[-1])


class RunFuncTestCase(BaseTestCase):
def run_python(self, code, **kwargs):
"""Run Python code in a subprocess using subprocess.run"""
Expand Down