Skip to content

gh-91456: Fix issue affecting the use of auto() alongside aliases in Enums #91457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanfurman merged 7 commits into from
Jun 23, 2022
Merged

gh-91456: Fix issue affecting the use of auto() alongside aliases in Enums #91457

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e8480c
Fix issue affecting the use of auto() alongside aliases in Enums
oscar-LT Apr 11, 2022
61ac223
Improve Fix and add test case as requested
oscar-LT Apr 11, 2022
eec3993
Check Incrementable instead of type checking
oscar-LT Apr 14, 2022
606e29a
Update function doc_string for last_values arg
oscar-LT Apr 14, 2022
c3e91e8
Improve time complexity by using filter()
oscar-LT Apr 18, 2022
8769a2e
Forgot to specify exception type (TypeError)
oscar-LT Apr 18, 2022
d65aaf4
deprecate current behavior
ethanfurman Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve time complexity by using filter()
  • Loading branch information
@oscar-LT @ethanfurman
oscar-LT authored and ethanfurman committed Jun 22, 2022
commit c3e91e80a246b87e450cf9879c9cffeb27872e0f
19 changes: 11 additions & 8 deletions Lib/enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,15 +1214,18 @@ def _generate_next_value_(name, start, count, last_values):
count: the number of existing members
last_values: the list of values assigned
"""
incrementable_last_values = []
for val in last_values:
try:
incrementable_last_values.append(val + 1)
except TypeError:
pass

if incrementable_last_values:
return sorted(incrementable_last_values)[-1]
# Filter funciton to deal with last_values lists of mixed types
def test_incrementable(n):
try:
n + 1
return True
except:
return False

checked_last_values = sorted(filter(test_incrementable, last_values))
if checked_last_values:
return checked_last_values[-1] + 1
else:
return start

Expand Down