[Skip Issue] tokenizer.c: Replace unneeded PyUnicode_READY() with an assertion#9114
Merged
serhiy-storchaka merged 2 commits intoSep 10, 2018
Merged
Conversation
In verify_identifier(), PyUnicode_READY(s) == -1 would never occur (PyUnicode_DecodeUTF8() always returns a ready string on success). Also, if PyUnicode_READY(s) == -1 did actually occur here, there would be a reference leak.
| } | ||
| return 0; | ||
| } | ||
| assert(PyUnicode_IS_READY(s)); |
Member
There was a problem hiding this comment.
This assert is not needed sincePyUnicode_IsIdentifier() calls PyUnicode_READY().
Contributor
Author
There was a problem hiding this comment.
True. I added this assertion mainly because new_identifier() in ast.c has it immediately after PyUnicode_DecodeUTF8().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In verify_identifier(), PyUnicode_READY(s) == -1 would never occur
(PyUnicode_DecodeUTF8() always returns a ready string on success).
Also, if PyUnicode_READY(s) == -1 did actually occur here, there would
be a reference leak.