Skip to content

bpo-34573: Simplify __reduce__() of set and dict iterators.#9050

Merged
pablogsal merged 2 commits into
python:masterfrom
sir-sigurd:setiter-reduce
Oct 20, 2018
Merged

bpo-34573: Simplify __reduce__() of set and dict iterators.#9050
pablogsal merged 2 commits into
python:masterfrom
sir-sigurd:setiter-reduce

Conversation

@sir-sigurd
Copy link
Copy Markdown
Contributor

@sir-sigurd sir-sigurd commented Sep 4, 2018

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serhiy-storchaka serhiy-storchaka self-assigned this Sep 7, 2018
@vstinner
Copy link
Copy Markdown
Member

@pablogsal: You showed me an awful corner case on a similar change for OrderedDict. So now I'm scared to approve such change for other types... Would it mind to approve it? (and maybe also merge it)

Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That corner case is a derivative of what is being handled in #9051. I think this is fine :)

@pablogsal pablogsal merged commit 6395844 into python:master Oct 20, 2018
@sir-sigurd sir-sigurd deleted the setiter-reduce branch October 20, 2018 10:10
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants