Skip to content

bpo-34472: Add data descriptor signature to zipfile#8871

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
silas:zipfile-data-descriptor-signature
Sep 18, 2018
Merged

bpo-34472: Add data descriptor signature to zipfile#8871
serhiy-storchaka merged 1 commit into
python:masterfrom
silas:zipfile-data-descriptor-signature

Conversation

@silas
Copy link
Copy Markdown
Contributor

@silas silas commented Aug 23, 2018 •
edited
Loading

This makes streamed zips compatible with MacOS Archive Utility and other applications.

https://bugs.python.org/issue34472

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Aug 23, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@silas
bpo-34472: Add data descriptor signature to zipfile (GH-8871)
e4db231 
This makes streamed zips compatible with MacOS Archive Utility and
other applications.
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Sep 18, 2018
@serhiy-storchaka serhiy-storchaka merged commit 4ba3b50 into python:master Sep 18, 2018
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 and removed type-feature A feature request or enhancement labels Sep 18, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 18, 2018

Thanks @silas for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 18, 2018

Thanks @silas for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 18, 2018

Thanks @silas for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 18, 2018

GH-9398 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2018
@silas @miss-islington
bpo-34472: Add data descriptor signature to zipfile (pythonGH-8871)
aa7d144 
This makes streamed zips compatible with MacOS Archive Utility and
other applications.
(cherry picked from commit 4ba3b50)

Co-authored-by: Silas Sewell <silas@sewell.org>
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 18, 2018

Sorry, @silas and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4ba3b50bfe6d50cd82d208023ea23e203ab50589 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2018
@silas @miss-islington
bpo-34472: Add data descriptor signature to zipfile (pythonGH-8871)
236eb00 
This makes streamed zips compatible with MacOS Archive Utility and
other applications.
(cherry picked from commit 4ba3b50)

Co-authored-by: Silas Sewell <silas@sewell.org>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 18, 2018

GH-9399 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 18, 2018

Thanks @silas for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 18, 2018

Sorry, @silas and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4ba3b50bfe6d50cd82d208023ea23e203ab50589 2.7

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Sep 18, 2018
@silas @serhiy-storchaka
[2.7] bpo-34472: Add data descriptor signature to zipfile (pythonGH-8871
35677b9 
)

This makes streamed zips compatible with MacOS Archive Utility and
other applications..
(cherry picked from commit 4ba3b50)

Co-authored-by: Silas Sewell <silas@sewell.org>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 18, 2018

GH-9407 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka added a commit that referenced this pull request Sep 22, 2018
@serhiy-storchaka @silas
[2.7] bpo-34472: Add data descriptor signature to zipfile (GH-8871) (…
6ec2981 
…ПР-9407)

This makes streamed zips compatible with MacOS Archive Utility and
other applications.
(cherry picked from commit 4ba3b50)

Co-authored-by: Silas Sewell <silas@sewell.org>
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 22, 2018
serhiy-storchaka pushed a commit that referenced this pull request Sep 22, 2018
@miss-islington @silas @serhiy-storchaka
bpo-34472: Add data descriptor signature to zipfile (GH-8871) (GH-9398)
ed21919 
This makes streamed zips compatible with MacOS Archive Utility and
other applications.
(cherry picked from commit 4ba3b50)

Co-authored-by: Silas Sewell <silas@sewell.org>
serhiy-storchaka pushed a commit that referenced this pull request Sep 22, 2018
@miss-islington @silas @serhiy-storchaka
bpo-34472: Add data descriptor signature to zipfile (GH-8871) (GH-9399)
44989bc 
This makes streamed zips compatible with MacOS Archive Utility and
other applications.
(cherry picked from commit 4ba3b50)

Co-authored-by: Silas Sewell <silas@sewell.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@silas @the-knights-who-say-ni @miss-islington @bedevere-bot @serhiy-storchaka