Skip to content

bpo-34427: islice values when calling MutableSequence.extend on self#8813

Merged
rhettinger merged 6 commits into
python:masterfrom
KittenHero:mutablesequence.extend
Aug 30, 2018
Merged

bpo-34427: islice values when calling MutableSequence.extend on self#8813
rhettinger merged 6 commits into
python:masterfrom
KittenHero:mutablesequence.extend

Conversation

@KittenHero
Copy link
Copy Markdown
Contributor

@KittenHero KittenHero commented Aug 19, 2018 •
edited by bedevere-bot
Loading

@KittenHero KittenHero requested a review from rhettinger as a code owner August 19, 2018 02:04
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Aug 19, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

rhettinger
rhettinger requested changes Aug 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhettinger rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We don't want to create another dependency.

  • Instead, is it better to use plain Python with no external calls.

  • Instead of an islice() approach, emulate what was done for list_extend() in Objects/listobject.c and for deque_extend() in Modules/_collectionsmodule.c. When "values is self", create a copy first using "list(values)".

  • The patch also needs tests and a news blurb.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 20, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@KittenHero
Copy link
Copy Markdown
Contributor Author

KittenHero commented Aug 20, 2018

Thanks, I will have a look at those

@KittenHero KittenHero force-pushed the mutablesequence.extend branch 2 times, most recently from 4446de1 to a31e3d5 Compare August 20, 2018 04:07
@KittenHero KittenHero force-pushed the mutablesequence.extend branch from b0294a2 to 4302472 Compare August 20, 2018 14:44
@KittenHero KittenHero force-pushed the mutablesequence.extend branch from 4302472 to 89f6ab2 Compare August 20, 2018 14:51
@KittenHero
Copy link
Copy Markdown
Contributor Author

KittenHero commented Aug 21, 2018

I made the requested changes I think

@rhettinger rhettinger merged commit 1b5f9c9 into python:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KittenHero @the-knights-who-say-ni @bedevere-bot @rhettinger