Skip to content

bpo-34430 Symmetrical chaining futures in asyncio.future.wrap_future#8806

Closed
alfred-sa wants to merge 1 commit into
python:masterfrom
alfred-sa:asyncio_wrap_future_symmetrical
Closed

bpo-34430 Symmetrical chaining futures in asyncio.future.wrap_future#8806
alfred-sa wants to merge 1 commit into
python:masterfrom
alfred-sa:asyncio_wrap_future_symmetrical

Conversation

@alfred-sa
Copy link
Copy Markdown

@alfred-sa alfred-sa commented Aug 18, 2018

The two futures chained by :func:asyncio.future.wrap_future are now
symmetrical.

Before, the behaviour was:

  1. When the wrapped future gets a result, the new future gets the same result,
  2. When the new future is cancelled, the wrapped future is cancelled

now, these new behaviours have been implemented:
3) When the new future gets a result, the wrapped future gets the same result,
4) When the wrapped future is cancelled, the new future is cancelled

so, the new behaviour is:

  1. When either one future is done, the other is done with the same results or exceptions,
  2. When either one future is cancelled, the other is cancelled.

https://bugs.python.org/issue34430

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@alfred-sa alfred-sa closed this Aug 18, 2018
@alfred-sa alfred-sa deleted the asyncio_wrap_future_symmetrical branch August 18, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants