Adds boolean support.

python · rhettinger · Sep 14, 2018 · Aug 12, 2018 · Aug 16, 2018 · Aug 22, 2018
commit 3cd076c01428c89ac75ffc4e2ff1c5664576fb08
diff --git a/Doc/library/stdtypes.rst b/Doc/library/stdtypes.rst
@@ -541,9 +541,10 @@ class`. In addition, it provides a few more methods:
 
 .. method:: int.as_integer_ratio()
 
-   Return a pair of integers whose ratio is exactly equal to the original integer
-   and with a positive denominator. The integer ratio of integers (whole numbers)
-   is always the integer as the numerator and 1 as the denominator.
+   Return a pair of integers whose ratio is exactly equal to the original
+   integer and with a positive denominator. The integer ratio of integers
+   (whole numbers) is always the integer as the numerator and 1 as the
+   denominator.
 
    .. versionadded:: 3.8
 

diff --git a/Doc/whatsnew/3.8.rst b/Doc/whatsnew/3.8.rst
@@ -94,6 +94,10 @@ Other Language Changes
 * Added support of ``\N{name}`` escapes in :mod:`regular expressions <re>`.
   (Contributed by Jonathan Eunice and Serhiy Storchaka in :issue:`30688`.)
 
+* The ``int`` type now has a new ``as_integer_ratio`` method compatible
+  with the existing ``float.as_integer_ratio`` method.
+  (Contributed by Lisa Roach in :issue:`33073`.)
+
 
 New Modules
 ===========

diff --git a/Lib/test/test_doctest.py b/Lib/test/test_doctest.py
@@ -665,7 +665,7 @@ def non_Python_modules(): r"""
     True
     >>> real_tests = [t for t in tests if len(t.examples) > 0]
     >>> len(real_tests) # objects that actually have doctests
-    8
+    9
     >>> for t in real_tests:
     ...     print('{}  {}'.format(len(t.examples), t.name))
     ...
@@ -675,6 +675,7 @@ def non_Python_modules(): r"""
     2  builtins.float.hex
     1  builtins.hex
     1  builtins.int
+    4  builtins.int.as_integer_ratio
     2  builtins.int.bit_length
     1  builtins.oct
 

diff --git a/Lib/test/test_long.py b/Lib/test/test_long.py
@@ -1350,9 +1350,17 @@ def test_shift_bool(self):
                 self.assertEqual(type(value >> shift), int)
 
     def test_as_integer_ratio(self):
-        tests = [10, 0, -10, 1, 3]
+        tests = [10, 0, -10, 1]
         for value in tests:
-            self.assertEqual(value.as_integer_ratio(), (value, 1))
+            numerator, denominator = value.as_integer_ratio()
+            self.assertEqual((numerator, denominator), (value, 1))
+            self.assertIsInstance(numerator, int)
+            self.assertIsInstance(denominator, int)
+
+    def test_as_integer_ratio_bool(self):
+        self.assertEqual(True.as_integer_ratio(), (1, 1))
+        self.assertEqual(False.as_integer_ratio(), (0, 1))
+
 
 
 if __name__ == "__main__":

diff --git a/Misc/ACKS b/Misc/ACKS
@@ -1347,6 +1347,7 @@ Juan M. Bello Rivas
 Mohd Sanad Zaki Rizvi
 Davide Rizzo
 Anthony Roach
+Lisa Roach
 Carl Robben
 Ben Roberts
 Mark Roberts

diff --git a/Objects/clinic/longobject.c.h b/Objects/clinic/longobject.c.h
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -5280,9 +5280,13 @@ and with a positive denominator.
 
 static PyObject *
 int_as_integer_ratio_impl(PyObject *self)
-/*[clinic end generated code: output=e60803ae1cc8621a input=ce9c7768a1287fb9]*/
+/*[clinic end generated code: output=e60803ae1cc8621a input=c1aea0aa6fb85c28]*/
 {
-    return PyTuple_Pack(2, self, _PyLong_One);
+  if (self == Py_True)
+    return PyTuple_Pack(2, _PyLong_One, _PyLong_One);
+  if (self == Py_False)
+    return PyTuple_Pack(2, _PyLong_Zero, _PyLong_One);
+  return PyTuple_Pack(2, self, _PyLong_One);
 }
 
 /*[clinic input]