Skip to content

bpo-34272: Reorganize C API tests.#8551

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
serhiy-storchaka:test_capi
Nov 10, 2022
Merged

bpo-34272: Reorganize C API tests.#8551
serhiy-storchaka merged 3 commits into
python:mainfrom
serhiy-storchaka:test_capi

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Jul 29, 2018 •
edited
Loading

Move most some C API tests into Lib/test/test_capi/.

https://bugs.python.org/issue34272

@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Jul 29, 2018
@arhadthedev
Copy link
Copy Markdown
Member

arhadthedev commented Mar 27, 2022

Is the idea to group C API tests still feasible? It would be great to immediately see from a file structure that test_getargs2.py and test_structmembers.py are not about Python libraries or their module backends.

iritkatriel
iritkatriel requested changes Nov 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts need to be resolved.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 9, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka
Copy link
Copy Markdown
Member Author

serhiy-storchaka commented Nov 10, 2022

Thank you for a reminder. I completely forget about this simple PR.

@serhiy-storchaka serhiy-storchaka merged commit f883b7f into python:main Nov 10, 2022
@serhiy-storchaka serhiy-storchaka deleted the test_capi branch November 10, 2022 06:54
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 10, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 10, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 10, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2022
@serhiy-storchaka @miss-islington
bpo-34272: Reorganize C API tests. (pythonGH-8551)
b91896a 
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 10, 2022

GH-99314 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 10, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2022
@serhiy-storchaka @miss-islington
bpo-34272: Reorganize C API tests. (pythonGH-8551)
d027568 
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 10, 2022

GH-99315 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 10, 2022
@encukou encukou mentioned this pull request Nov 10, 2022
Open
miss-islington added a commit that referenced this pull request Nov 12, 2022
@miss-islington @serhiy-storchaka
bpo-34272: Reorganize C API tests. (GH-8551)
ecc164f 
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Nov 12, 2022
@miss-islington @serhiy-storchaka
bpo-34272: Reorganize C API tests. (GH-8551)
535027f 
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ethanfurman pushed a commit to ethanfurman/cpython that referenced this pull request Nov 12, 2022
@serhiy-storchaka @ethanfurman
bpo-34272: Reorganize C API tests. (pythonGH-8551)
b0db4fe 
Move some C API tests into Lib/test/test_capi/.
This was referenced Apr 10, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel requested changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@serhiy-storchaka @arhadthedev @bedevere-bot @miss-islington @iritkatriel @auvipy @the-knights-who-say-ni @ezio-melotti