Skip to content

bpo-27351: Fix ConfigParser.read() documentation and docstring#8123

Merged
briancurtin merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-27351-configparser-read-docs-docstring
Sep 29, 2018
Merged

bpo-27351: Fix ConfigParser.read() documentation and docstring#8123
briancurtin merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-27351-configparser-read-docs-docstring

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Jul 5, 2018 •
edited by bedevere-bot
Loading

Switch "list" to "iterable" to match with the implementation.

https://bugs.python.org/issue27351

@ZackerySpytz
bpo-27351: Fix ConfigParser.read() documentation and docstring
a5d96f8 
Switch "list" with "iterable" to match with the implementation.
@ZackerySpytz ZackerySpytz force-pushed the bpo-27351-configparser-read-docs-docstring branch from 2ce0441 to a5d96f8 Compare July 6, 2018 00:42
@methane methane added docs Documentation in the Doc dir skip news labels Jul 6, 2018
@ZackerySpytz
Copy link
Copy Markdown
Contributor Author

ZackerySpytz commented Jul 11, 2018

The bot failed to link this PR with bpo-27351 (mentioning the issue number here in a comment will fix that).

BoboTiG
BoboTiG approved these changes Jul 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@BoboTiG BoboTiG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)
The changes seem fine to me.

@briancurtin briancurtin merged commit e45473e into python:master Sep 29, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 29, 2018

Thanks @ZackerySpytz for the PR, and @briancurtin for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2018
@ZackerySpytz @miss-islington
bpo-27351: Fix ConfigParser.read() documentation and docstring (pytho…
3154d06 
…nGH-8123)

Switch "list" with "iterable" to match with the implementation.
(cherry picked from commit e45473e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 29, 2018

GH-9637 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2018
@ZackerySpytz @miss-islington
bpo-27351: Fix ConfigParser.read() documentation and docstring (pytho…
6280e9d 
…nGH-8123)

Switch "list" with "iterable" to match with the implementation.
(cherry picked from commit e45473e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 29, 2018

GH-9638 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 29, 2018

Sorry, @ZackerySpytz and @briancurtin, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e45473e3ca31e5b78dc85cab575f5bb60d5b7f8f 2.7

briancurtin pushed a commit that referenced this pull request Sep 29, 2018
@miss-islington @ZackerySpytz @briancurtin
bpo-27351: Fix ConfigParser.read() documentation and docstring (GH-8123)
b0b8f9b 
Switch "list" with "iterable" to match with the implementation.
(cherry picked from commit e45473e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
briancurtin pushed a commit that referenced this pull request Sep 29, 2018
@miss-islington @ZackerySpytz @briancurtin
bpo-27351: Fix ConfigParser.read() documentation and docstring (GH-8123)
3cd5e8e 
Switch "list" with "iterable" to match with the implementation.
(cherry picked from commit e45473e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briancurtin briancurtin briancurtin approved these changes

+1 more reviewer

@BoboTiG BoboTiG BoboTiG approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@briancurtin briancurtin

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZackerySpytz @miss-islington @bedevere-bot @briancurtin @BoboTiG @methane @the-knights-who-say-ni