Skip to content

bpo-34031: fix incorrect usage of self.fail in 2 unittests #8091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taleinat merged 2 commits into from
Jul 10, 2018
Merged

bpo-34031: fix incorrect usage of self.fail in 2 unittests #8091

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58991bd
bpo-34031: fix incorrect usage of self.fail in 2 unittests
stoksc Jul 4, 2018
67dfc31
requested changes
stoksc Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
requested changes
  • Loading branch information
@stoksc
stoksc committed Jul 5, 2018
commit 67dfc3143e844464db53dedfbe69646415fb9cd5
3 changes: 1 addition & 2 deletions Lib/test/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,7 @@ def testIteration(self):
# Test for appropriate errors mixing read* and iteration
for methodname, args in methods:
f = self.open(TESTFN, 'rb')
if next(f) != filler:
self.fail("Broken testfile")
self.assertEqual(next(f), filler)
meth = getattr(f, methodname)
meth(*args) # This simply shouldn't fail
f.close()
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_urllib2_localnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def test_basic_auth_success(self):
try:
self.assertTrue(urllib.request.urlopen(self.server_url))
except urllib.error.HTTPError:
self.fail(f"Basic auth failed for the url: {self.server_url}")
self.fail("Basic auth failed for the url: %s" % self.server_url)

def test_basic_auth_httperror(self):
ah = urllib.request.HTTPBasicAuthHandler()
Expand Down