Skip to content

bpo-33833: Fix ProactorSocketTransport AssertionError (v2)#7893

Merged
asvetlov merged 7 commits into
python:masterfrom
twisteroidambassador:bpo33833
Jul 30, 2018
Merged

bpo-33833: Fix ProactorSocketTransport AssertionError (v2)#7893
asvetlov merged 7 commits into
python:masterfrom
twisteroidambassador:bpo33833

Conversation

@twisteroidambassador
Copy link
Copy Markdown
Contributor

@twisteroidambassador twisteroidambassador commented Jun 24, 2018 •
edited by bedevere-bot
Loading

We have a fix, a unit test, and a blurb. Hopefully it's ready for merge.

https://bugs.python.org/issue33833

@GoldenOne1
Copy link
Copy Markdown

GoldenOne1 commented Jul 14, 2018

When this fix will be released?

asvetlov
asvetlov approved these changes Jul 30, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1st1 would be nice to get your review too

@1st1
Copy link
Copy Markdown
Member

1st1 commented Jul 30, 2018

I think the fix is OK. BTW, @twisteroidambassador if you're interested in doing proper refactoring (or a rewrite) of Proactor we need help for that :)

@asvetlov asvetlov merged commit 9045199 into python:master Jul 30, 2018
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 30, 2018

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 30, 2018

Thanks @twisteroidambassador for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2018
@twisteroidambassador @miss-islington
bpo-33833: Fix ProactorSocketTransport AssertionError (pythonGH-7893)
e5a4042 
(cherry picked from commit 9045199)

Co-authored-by: twisteroid ambassador <twisteroidambassador@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 30, 2018

GH-8575 is a backport of this pull request to the 3.7 branch.

@asvetlov
Copy link
Copy Markdown
Contributor

asvetlov commented Jul 30, 2018

thanks!

miss-islington added a commit that referenced this pull request Jul 30, 2018
@miss-islington @twisteroidambassador
bpo-33833: Fix ProactorSocketTransport AssertionError (GH-7893)
d5c75be 
(cherry picked from commit 9045199)

Co-authored-by: twisteroid ambassador <twisteroidambassador@users.noreply.github.com>
@GoldenOne1
Copy link
Copy Markdown

GoldenOne1 commented Jul 30, 2018

Will this fix available in version 3.7.1 ?

@1st1
Copy link
Copy Markdown
Member

1st1 commented Jul 30, 2018

Yes

@GoldenOne1
Copy link
Copy Markdown

GoldenOne1 commented Jul 31, 2018

@1st1

Maintenance releases 3.7.1
Expected: 2018-07-xx

Today is 2018/07/31

@twisteroidambassador
Copy link
Copy Markdown
Contributor Author

twisteroidambassador commented Jul 31, 2018

Maintenance releases 3.7.1
Expected: 2018-07-xx

Today is 2018/07/31

The fact that on the last day of 2018-07 the "Expected" date is still not a specific date means, I have to assume, that 3.7.1 will miss its target and will not be released in 2018-07. So don't worry just yet.

@1st1 I'm interested, but probably not yet capable of doing a refactor properly. ;-) I'll work my way there.

@twisteroidambassador twisteroidambassador mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@twisteroidambassador @GoldenOne1 @1st1 @bedevere-bot @miss-islington @asvetlov @the-knights-who-say-ni