Skip to content

bpo-33921: Clarify how to bind to all interfaces using socket#7877

Merged
tiran merged 3 commits into
python:masterfrom
johnthagen:patch-1
Jul 28, 2018
Merged

bpo-33921: Clarify how to bind to all interfaces using socket#7877
tiran merged 3 commits into
python:masterfrom
johnthagen:patch-1

Conversation

@johnthagen

@johnthagen johnthagen commented Jun 23, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented Jun 23, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@johnthagen

johnthagen commented Jun 23, 2018

Copy link
Copy Markdown
Contributor Author

Updated b.p.o account to associate GitHub username.

ammaraskar
ammaraskar requested changes Jun 23, 2018
View reviewed changes
Comment thread Doc/library/socket.rst Outdated
notation like ``'daring.cwi.nl'`` or an IPv4 address like ``'100.50.200.5'``,
and *port* is an integer.

- For IPv4 addresses, two special forms are accepted instead of a host

@ammaraskar ammaraskar Jun 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got trailing whitespace on some of these lines, aside from that the content looks good.

@ammaraskar

ammaraskar commented Jun 23, 2018

Copy link
Copy Markdown
Member

Still one line left with trailing whitespace: https://travis-ci.org/python/cpython/jobs/395902432#L544

fyi, you can catch these locally before pushing by running make patchcheck https://devguide.python.org/pullrequest/#patchcheck

@johnthagen

johnthagen commented Jun 23, 2018

Copy link
Copy Markdown
Contributor Author

@ammaraskar Thanks for the heads up. Been editing in the browser for this for simplicity, but I'll note that for next time if it's a more substantial PR.

ammaraskar
ammaraskar approved these changes Jun 23, 2018
View reviewed changes

@ammaraskar ammaraskar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can be marked with skip news since its a minor doc change.

@johnthagen

johnthagen commented Jul 1, 2018

Copy link
Copy Markdown
Contributor Author

@ned-deily Are you available to review?

@tiran tiran merged commit 95dfb9c into python:master Jul 28, 2018
@miss-islington

miss-islington commented Jul 28, 2018

Copy link
Copy Markdown
Contributor

Thanks @johnthagen for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2018
@johnthagen @miss-islington
bpo-33921: Clarify how to bind to all interfaces using socket (python…
fe2eac9 
…GH-7877)

Clarify how to bind to all interfaces using socket
(cherry picked from commit 95dfb9c)

Co-authored-by: johnthagen <johnthagen@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Jul 28, 2018

Copy link
Copy Markdown

GH-8513 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2018
@johnthagen @miss-islington
bpo-33921: Clarify how to bind to all interfaces using socket (python…
8d9195d 
…GH-7877)

Clarify how to bind to all interfaces using socket
(cherry picked from commit 95dfb9c)

Co-authored-by: johnthagen <johnthagen@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Jul 28, 2018

Copy link
Copy Markdown

GH-8514 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Jul 28, 2018
@miss-islington @johnthagen
bpo-33921: Clarify how to bind to all interfaces using socket (GH-7877)
2335544 
Clarify how to bind to all interfaces using socket
(cherry picked from commit 95dfb9c)

Co-authored-by: johnthagen <johnthagen@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jul 28, 2018
@miss-islington @johnthagen
bpo-33921: Clarify how to bind to all interfaces using socket (GH-7877)
30f295b 
Clarify how to bind to all interfaces using socket
(cherry picked from commit 95dfb9c)

Co-authored-by: johnthagen <johnthagen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

@ammaraskar ammaraskar ammaraskar approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@johnthagen @the-knights-who-say-ni @ammaraskar @miss-islington @bedevere-bot @tiran @ned-deily