bpo-33830: Fix http.client 404 docs#7780
Merged
serhiy-storchaka merged 2 commits intoDec 21, 2018
Merged
Conversation
ammaraskar
reviewed
Jun 19, 2018
| ... | ||
| >>> # Example of an invalid request | ||
| >>> conn.request("GET", "/parrot.spam") | ||
| >>> conn = http.client.HTTPSConnection("httpbin.org") |
Member
There was a problem hiding this comment.
I would suggest hitting a python host that is going to be up for the forseeable future. docs.python.org for example returns the "correct" message of 404 Not Found.
Member
Author
There was a problem hiding this comment.
Thanks, I have changed the the host to docs.python.org and tested the same.
serhiy-storchaka
approved these changes
Dec 21, 2018
Contributor
|
Thanks @tirkarthi for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11278 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 21, 2018
(cherry picked from commit f0af4c5) Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Dec 21, 2018
Member
Author
|
Thanks @serhiy-storchaka :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix invalid request in docs to return 404 NOT FOUND which currently returns 404 OK. I think using an example with 404 OK is misleading and couldn't find an endpoint that returns 404 NOT FOUND in python.org . pythontest.net used for test suite doesn't have https in it.
This needs to fixed in 2.7 where '/' instead of '/parrot.spam' which is also incorrect.
Please add skip-news label for this
Thanks
https://bugs.python.org/issue33830