Skip to content

bpo-33604: Remove deprecated HMAC default value marked for removal in 3.8#7063

Merged
gpshead merged 2 commits into
python:masterfrom
Carreau:hmac-digestomod-removal
Sep 10, 2018
Merged

bpo-33604: Remove deprecated HMAC default value marked for removal in 3.8#7063
gpshead merged 2 commits into
python:masterfrom
Carreau:hmac-digestomod-removal

Conversation

@Carreau
Copy link
Copy Markdown
Contributor

@Carreau Carreau commented May 22, 2018 •
edited by bedevere-bot
Loading

HMAC's digestmod was deprecated marked for removal in 3.6, then to 3.8 (in #7062).

This is on top of #7062, which fix the deprecation notice to use the correct Python version.

https://bugs.python.org/issue33604

@tiran tiran requested a review from gpshead May 22, 2018 20:54
gpshead
gpshead requested changes May 22, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor edits. overall I'm okay with this but lets wait for the PR marking it fully deprecated in 3.7 to go in first.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 22, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Carreau Carreau force-pushed the hmac-digestomod-removal branch from 6ebeb17 to 359d355 Compare May 23, 2018 02:10
@Carreau
Copy link
Copy Markdown
Contributor Author

Carreau commented May 23, 2018

I made some minor edits

AH, yes, thank you, much better.

overall I'm okay with this but lets wait for the PR marking it fully deprecated in 3.7 to go in first.

Yes that was the plan.
I rebased because of conflict.
I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 23, 2018

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

Carreau and others added 2 commits May 24, 2018 20:28
@Carreau
bpo-33604: Remove deprecated HMAC default value marked for removal in…
85f6c59 
… 3.8

HMAC's digestmod was deprecated marked for removal in 3.6, then bumped
to 3.8
@gpshead @Carreau
docstring wording and fix typo in the ValueError.
d74f873 
lets not mention the old behavior in the docstring and explicitly document that the `digestmod` parameter is required.
@Carreau Carreau force-pushed the hmac-digestomod-removal branch from 359d355 to d74f873 Compare May 25, 2018 03:29
@gpshead gpshead merged commit 51a4743 into python:master Sep 10, 2018
@Carreau Carreau deleted the hmac-digestomod-removal branch September 10, 2018 19:57
@Carreau
Copy link
Copy Markdown
Contributor Author

Carreau commented Sep 10, 2018

Thanks, Much appreciated. I'm guessing you'll be at the core-dev sprint, and wish you all to enjoy it (but still take some time off).

moreati added a commit to moreati/cpython that referenced this pull request Jun 10, 2019
@moreati
bpo-37218: Change digestmod deprecation notice to versionchanged
fa8d736 
Code change was made in python#7063, for
https://bugs.python.org/issue33604.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

@tiran tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Carreau @bedevere-bot @gpshead @tiran @the-knights-who-say-ni