Skip to content

bpo-32604: Implement force-closing channels. #6937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 3 commits into from
May 17, 2018
Merged

bpo-32604: Implement force-closing channels. #6937

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c3e149
Add ChannelNotEmptyError.
ericsnowcurrently Apr 24, 2018
d3a5b2b
Add force-close-related tests.
ericsnowcurrently Apr 24, 2018
d383744
Implement forcing for channel_close().
ericsnowcurrently Apr 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add ChannelNotEmptyError.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed May 17, 2018
commit 8c3e1493174807bb70930ba29f83d0d242fc3093
11 changes: 11 additions & 0 deletions Modules/_xxsubinterpretersmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ static PyObject *ChannelError;
static PyObject *ChannelNotFoundError;
static PyObject *ChannelClosedError;
static PyObject *ChannelEmptyError;
static PyObject *ChannelNotEmptyError;

static int
channel_exceptions_init(PyObject *ns)
Expand Down Expand Up @@ -356,6 +357,16 @@ channel_exceptions_init(PyObject *ns)
return -1;
}

// An operation tried to close a non-empty channel.
ChannelNotEmptyError = PyErr_NewException(
"_xxsubinterpreters.ChannelNotEmptyError", ChannelError, NULL);
if (ChannelNotEmptyError == NULL) {
return -1;
}
if (PyDict_SetItemString(ns, "ChannelNotEmptyError", ChannelNotEmptyError) != 0) {
return -1;
}

return 0;
}

Expand Down