bpo-33421: Add AsyncContextManager to typing module documentation.#6700
bpo-33421: Add AsyncContextManager to typing module documentation.#6700twavv wants to merge 1 commit into
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
ilevkivskyi
left a comment
There was a problem hiding this comment.
LGTM. Thank you for adding this!
|
Oh, wait. why are you making the PR to the 3.6 branch? It looks like this also needs to be added to 3.7 and master. Could you please close this one and re-open w.r.t. master branch? I will then merge and backport to other relevant branches (this is how things are normally done here). |
|
Okay, I'll mention you in the new pull request. |
|
Actually, 3.7+ has A generic version of ...so for 3.7 we could say A generic version of :class:`contextlib.AbstractAsyncContextManager`.but not for 3.6. In fact, seems 3.6 has some weird dodging around the absence of |
|
It is OK to have different text for different versions. You can make two PRs, one against master with |
https://bugs.python.org/issue33421