Skip to content

[2.7] bpo-33280: Reorganize external Tcl/Tk references. (GH-6473).#6603

Closed
andresdelfino wants to merge 1 commit into
python:2.7from
andresdelfino:backport-67a8f4f-2.7
Closed

[2.7] bpo-33280: Reorganize external Tcl/Tk references. (GH-6473).#6603
andresdelfino wants to merge 1 commit into
python:2.7from
andresdelfino:backport-67a8f4f-2.7

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

(cherry picked from commit 67a8f4f)

Co-authored-by: Andrés Delfino 34587441+andresdelfino@users.noreply.github.com

https://bugs.python.org/issue33280

(cherry picked from commit 67a8f4f)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
@andresdelfino

Copy link
Copy Markdown
Contributor Author

Please do not merge. :mod:tkinter must be updated to :mod:Tkinter. I'm figuring out how to modify this PR.

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why you closed this and deleted the branch. One simple change, which I could do on the web form if this were still open, and this would seem good to go.

Comment thread Doc/library/tkinter.rst
is maintained at ActiveState.)

Running ``python -m Tkinter`` from the command line should open a window
demonstrating a simple Tk interface, letting you know that :mod:`tkinter` is

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change needed before merging this is Tkinter instead of tkinter here

Comment thread Doc/library/tkinter.rst
platforms, as well as on Windows systems. (Tk itself is not part of Python; it
is maintained at ActiveState.)

Running ``python -m Tkinter`` from the command line should open a window

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this works on 2.7 and displays the tk version.

@andresdelfino

andresdelfino commented Jun 25, 2018

Copy link
Copy Markdown
Contributor Author

Sorry, I should have added a note. This was followed in #6607

@andresdelfino

andresdelfino commented Jun 25, 2018

Copy link
Copy Markdown
Contributor Author

I believe this was my first backport. Back then, I didn't knew I could checkout a remote branch to resume working on it (as cherry_picker deletes the branch after pushing it). That's why I decided to make another PR, close this one and delete the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants