Skip to content

bpo-33202 fix os.walk mentioning os.listdir instead of os.scandir#6335

Merged
benjaminp merged 3 commits into
python:masterfrom
andresdelfino:listdir_fix
Apr 3, 2018
Merged

bpo-33202 fix os.walk mentioning os.listdir instead of os.scandir#6335
benjaminp merged 3 commits into
python:masterfrom
andresdelfino:listdir_fix

Conversation

@andresdelfino
Copy link
Copy Markdown
Contributor

@andresdelfino andresdelfino commented Apr 1, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Apr 1, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@andresdelfino andresdelfino changed the title fix os.walk mentioning os.listdir instead of os.scandir bpo-33202 fix os.walk mentioning os.listdir instead of os.scandir Apr 1, 2018
@benjaminp benjaminp merged commit badb894 into python:master Apr 3, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 3, 2018

Thanks @andresdelfino for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2018
@andresdelfino @miss-islington
closes bpo-33202: fix os.walk mentioning os.listdir instead of os.sca…
e39196f 
…ndir (pythonGH-6335)

(cherry picked from commit badb894)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 3, 2018

GH-6359 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2018
@andresdelfino @miss-islington
closes bpo-33202: fix os.walk mentioning os.listdir instead of os.sca…
be1ded0 
…ndir (pythonGH-6335)

(cherry picked from commit badb894)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 3, 2018

GH-6360 is a backport of this pull request to the 3.6 branch.

@andresdelfino andresdelfino deleted the listdir_fix branch April 3, 2018 02:56
miss-islington added a commit that referenced this pull request Apr 3, 2018
@miss-islington @andresdelfino
closes bpo-33202: fix os.walk mentioning os.listdir instead of os.sca…
f6d1d65 
…ndir (GH-6335)

(cherry picked from commit badb894)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Apr 3, 2018
@miss-islington @andresdelfino
closes bpo-33202: fix os.walk mentioning os.listdir instead of os.sca…
fa5157e 
…ndir (GH-6335)

(cherry picked from commit badb894)

Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andresdelfino @the-knights-who-say-ni @miss-islington @bedevere-bot @benjaminp @Mariatta