Skip to content

bpo-32999: Convert useless check to assert#6197

Merged
methane merged 1 commit into
python:masterfrom
methane:bpo32999-assert
Mar 23, 2018
Merged

bpo-32999: Convert useless check to assert#6197
methane merged 1 commit into
python:masterfrom
methane:bpo32999-assert

Conversation

@methane

@methane methane commented Mar 23, 2018

Copy link
Copy Markdown
Member

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch!

@methane methane merged commit c65bf3f into python:master Mar 23, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@methane methane deleted the bpo32999-assert branch March 23, 2018 09:19
@bedevere-bot

Copy link
Copy Markdown

GH-6198 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
(cherry picked from commit c65bf3f)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 23, 2018
(cherry picked from commit c65bf3f)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants