bpo-32505: dataclasses: raise TypeError if a member variable is of type Field, but doesn't have a type annotation.#6192
Merged
ericvsmith merged 3 commits intoMar 22, 2018
Merged
Conversation
…ion. Reuse the class's annotations. Add tests.
Contributor
|
Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-6193 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 22, 2018
…pe Field, but doesn't have a type annotation. (pythonGH-6192) If a dataclass has a member variable that's of type Field, but it doesn't have a type annotation, raise TypeError. (cherry picked from commit 56970b8) Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
jo2y
pushed a commit
to jo2y/cpython
that referenced
this pull request
Mar 23, 2018
…pe Field, but doesn't have a type annotation. (pythonGH-6192) If a dataclass has a member variable that's of type Field, but it doesn't have a type annotation, raise TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32505