bpo-32999: Revert GH-6002 (fc7df0e6)#6189
Merged
Merged
Conversation
bpo-33018 (pythonGH-5944) fixed bpo-32999 too. So fc7df0e is not required anymore. Revert it except test case.
ilevkivskyi
reviewed
Mar 22, 2018
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks! Just one comment.
| end: | ||
| Py_DECREF(impl); | ||
| Py_XDECREF(mro); | ||
| Py_XDECREF(impl); |
Member
There was a problem hiding this comment.
I think this can stay DECREF, since impl can't be NULL here.
ilevkivskyi
approved these changes
Mar 22, 2018
Contributor
|
Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 22, 2018
bpo-33018 (pythonGH-5944) fixed bpo-32999 too. So fc7df0e is not required anymore. Revert it except test case. (cherry picked from commit f757b72) Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
ilevkivskyi
pushed a commit
that referenced
this pull request
Mar 22, 2018
zhangyangyu
reviewed
Mar 22, 2018
| assert(PyTuple_Check(mro)); | ||
| for (pos = 0; pos < PyTuple_GET_SIZE(mro); pos++) { | ||
| PyObject *mro_item = PyTuple_GET_ITEM(mro, pos); | ||
| if (mro_item == NULL) { |
Member
There was a problem hiding this comment.
@methane Late review, this check is redundant or not right. To keep it, you need to set an exception in the block, otherwise you are returning NULL without an exception, then SystemError.
Member
Author
There was a problem hiding this comment.
You're right. It should be assert(mro_item != NULL). I'll fix it tomorrow.
jo2y
pushed a commit
to jo2y/cpython
that referenced
this pull request
Mar 23, 2018
bpo-33018 (pythonGH-5944) fixed bpo-32999 too. So fc7df0e is not required anymore. Revert it except test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-33018 (GH-5944) fixed bpo-32999 too. So fc7df0e is not required
anymore. Revert it except test case.
https://bugs.python.org/issue32999