bpo-28124: clarify the two wrap_socket() are different#5963
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
I'm sorry I've signed CLA now. Should I re-submit the PR? |
|
Your CLA is not in the system yet. It takes a bit until it has been reviewed and confirmed. |
|
Thanks for the PR and sorry that it took so long for your contributor form to show up here. Unfortunately, in the mean time, @tiran has updated and expanded the whatsnew entry as a result of another issue so it looks like this PR is no longer needed. Since you are now in the system, your next contribution should go faster! |
|
Stop notifications please
…On Apr 13, 2018 6:17 AM, "Ned Deily" ***@***.***> wrote:
Closed #5963 <#5963>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5963 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AkNcU5It2BQqcGyYwchS8dp99utvMgX1ks5tn_WNgaJpZM4SatMM>
.
|
It looks confusing to say "wrap_socket() is deprecated. Documentation has been updated to recommend wrap_socket() instead." I removed "~" to show the full name of function/method.
Note that I didn't create an issue for this but refer to the original issue number.
https://bugs.python.org/issue28124