Clean up Travis config#5727
Conversation
berkerpeksag
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for cleaning it up! I just left a note about an older comment on the use of TRAVIS_COMMIT_RANGE.
| # Pull requests are slightly complicated because merging the PR commit without | ||
| # rebasing causes it to retain its old commit date. Meaning in history if any | ||
| # commits have been made on master that post-date it, they will be accidentally | ||
| # included in the diff if we use the TRAVIS_COMMIT_RANGE variable. |
There was a problem hiding this comment.
I'd still keep this comment (or a shorter version of it) to explain why we didn't use TRAVIS_COMMIT_RANGE here.
There was a problem hiding this comment.
Good point, re-added with a bit different wording.
Do note that I did change the logic used; it now matches what I added to AppVeyor last week since the current logic doesn't actually work as expected. I think it does work this way, but time will tell :)
|
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-5737 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 7eb3f82) Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
|
Sorry, @zware, I could not cleanly backport this to |
|
Sorry, @zware, I could not cleanly backport this to |
(cherry picked from commit 7eb3f82) Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
(cherry picked from commit 7eb3f82) Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
|
GH-5738 is a backport of this pull request to the 3.6 branch. |
(cherry picked from commit 7eb3f82) Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
|
GH-5740 is a backport of this pull request to the 2.7 branch. |
(cherry picked from commit 7eb3f82)
(cherry picked from commit 7eb3f82)
No description provided.